From 06adbc1e72978ff47af8ef1d81859d329a3b2ad4 Mon Sep 17 00:00:00 2001
From: sawinglogz <3787776-sawinglogz@users.noreply.gitlab.com>
Date: Wed, 13 Nov 2019 20:44:35 -0500
Subject: [PATCH] Mark any PRS1 sessions with empty slices as summary and skip
 event or waveform data.

If there are no mask-on slices of nonzero duration, then there's not any
meaningful event or waveform data for the session. There is occasionally some
fragmentary data, but it's always less than 1 second.

When such fragmentary waveform data is present, it only contains 1-3 nonzero
samples, corresponding to 0.2s - 0.6s of data, which suggests that the
mask-on slice was really that long rather than precisely 0.  As a result,
it appears that the timestamps of the mask-on/mask-off slices are just the
current value of the machine's internal clock, which only has 1-second
resolution.

But rather than embark on herculean efforts to derive a sub-second slice
duration from (only occasionally present) event or waveform data, we just
treat the session as having no detailed data.
---
 oscar/SleepLib/loader_plugins/prs1_loader.cpp | 14 ++++++++------
 oscar/tests/sessiontests.cpp                  | 12 ++++++++----
 2 files changed, 16 insertions(+), 10 deletions(-)

diff --git a/oscar/SleepLib/loader_plugins/prs1_loader.cpp b/oscar/SleepLib/loader_plugins/prs1_loader.cpp
index 5353de52..8804750e 100644
--- a/oscar/SleepLib/loader_plugins/prs1_loader.cpp
+++ b/oscar/SleepLib/loader_plugins/prs1_loader.cpp
@@ -7221,12 +7221,6 @@ bool PRS1Import::ParseSession(void)
             break;
         }
         
-        // If there's nothing beyond the compliance or summary (no event or waveform data), mark this session as
-        // a summary.
-        if (m_event_chunks.count() == 0 && m_wavefiles.isEmpty() && oxifile.isEmpty()) {
-            session->setSummaryOnly(true);
-        }
-
         // Import the slices into the session
         for (auto & slice : m_slices) {
             // Filter out 0-length slices, since they cause problems for Day::total_time().
@@ -7241,6 +7235,14 @@ bool PRS1Import::ParseSession(void)
             }
         }
         
+        // If are no mask-on slices, then there's not any meaningful event or waveform data for the session.
+        // If there's no no event or waveform data, mark this session as a summary.
+        if (session->m_slices.count() == 0 || (m_event_chunks.count() == 0 && m_wavefiles.isEmpty() && oxifile.isEmpty())) {
+            session->setSummaryOnly(true);
+            save = true;
+            break;  // and skip the occasional fragmentary event or waveform data
+        }
+
         // TODO: There should be a way to distinguish between no-data-to-import vs. parsing errors
         // (once we figure out what's benign and what isn't).
         if (m_event_chunks.count() > 0) {
diff --git a/oscar/tests/sessiontests.cpp b/oscar/tests/sessiontests.cpp
index 4ba5838c..303984e9 100644
--- a/oscar/tests/sessiontests.cpp
+++ b/oscar/tests/sessiontests.cpp
@@ -195,10 +195,14 @@ void SessionToYaml(QString filepath, Session* session, bool ok)
             out << "    end: " << ts(slice.end) << endl;
         }
     }
-    Day day;
-    day.addSession(session);
-    out << "  total_time: " << dur(day.total_time()) << endl;
-    day.removeSession(session);
+    qint64 total_time = 0;
+    if (session->first() != 0) {
+        Day day;
+        day.addSession(session);
+        total_time = day.total_time();
+        day.removeSession(session);
+    }
+    out << "  total_time: " << dur(total_time) << endl;
 
     out << "  settings:" << endl;