chris/OSCAR-code
1
0
Fork 0
mirror of https://gitlab.com/pholy/OSCAR-code.git synced 2025-04-06 19:20:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix memory leak in PRS1 unit test. Test runs now produce reproducible output.

Browse Source 
This fix also seems like it cleans up some of the weird session IDs. It appears
that session IDs were sticking around after each machine, adding those
IDs or sessions to subsequent machines in that run of the test. Since the
test was being run piecemeal while under development, this produced
different behavior when being run with different segments of the data.
This commit is contained in:
sawinglogz 2019-05-05 16:56:49 -04:00
parent e4082fff22
commit 2a9af3de0a
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
oscar/tests/prs1tests.cpp
View File

@ -51,9 +51,11 @@ void parseAndEmitSessionYaml(const QString & path)
// Each session now has a PRS1Import object in m_tasklist // Each session now has a PRS1Import object in m_tasklist
QList<ImportTask*>::iterator i; QList<ImportTask*>::iterator i;
for (i = s_loader->m_tasklist.begin(); i != s_loader->m_tasklist.end(); i++) { while (!s_loader->m_tasklist.isEmpty()) {
ImportTask* task = s_loader->m_tasklist.takeFirst();
// Run the parser // Run the parser
PRS1Import* import = dynamic_cast<PRS1Import*>(*i); PRS1Import* import = dynamic_cast<PRS1Import*>(task);
import->ParseSession(); import->ParseSession();
// Emit the parsed session data to compare against our regression benchmarks // Emit the parsed session data to compare against our regression benchmarks
@ -62,7 +64,7 @@ void parseAndEmitSessionYaml(const QString & path)
SessionToYaml(outpath, session); SessionToYaml(outpath, session);
delete session; delete session;
//delete import; // TODO: this crashes: there's a bug in the loader somewhere delete task;
} }
} }