From 423bfccc5af9a063e3b701058fbb627f5c55e4d4 Mon Sep 17 00:00:00 2001 From: sawinglogz <3787776-sawinglogz@users.noreply.gitlab.com> Date: Wed, 19 Jun 2019 17:50:41 -0400 Subject: [PATCH] Add a few comments for future 900X improvements. --- oscar/SleepLib/loader_plugins/prs1_loader.cpp | 10 ++++++++-- oscar/daily.cpp | 3 +++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/oscar/SleepLib/loader_plugins/prs1_loader.cpp b/oscar/SleepLib/loader_plugins/prs1_loader.cpp index d8ebc04f..98feda29 100644 --- a/oscar/SleepLib/loader_plugins/prs1_loader.cpp +++ b/oscar/SleepLib/loader_plugins/prs1_loader.cpp @@ -5343,8 +5343,11 @@ bool PRS1Import::ParseSession(void) qWarning() << sessionid << "compliance didn't set session end?"; } - // Events and waveforms use updateLast() to set the session's last timestamp, + // Events and use updateLast() to set the session's last timestamp, // so they should only reach this point if there was a problem parsing them. + + // TODO: It turns out waveforms *don't* update the timestamp, so this + // is depending entirely on events. See TODO below. if (event != nullptr || !wavefile.isEmpty() || !oxifile.isEmpty()) { qWarning() << sessionid << "Downgrading session to summary only"; } @@ -5352,7 +5355,10 @@ bool PRS1Import::ParseSession(void) // Only use the summary's duration if the session's duration couldn't be // derived from events or waveforms. - // TODO: Revisit this once summary parsing is reliable. + + // TODO: Change this once summary parsing is reliable: event duration is less + // accurate than either waveforms or correctly-parsed summaries, since there + // won't necessarily be events at the very end of a session. session->really_set_last(session->first()+(qint64(summary_duration) * 1000L)); } save = true; diff --git a/oscar/daily.cpp b/oscar/daily.cpp index dec0dbea..8d6f7b4b 100644 --- a/oscar/daily.cpp +++ b/oscar/daily.cpp @@ -1457,6 +1457,9 @@ void Daily::Load(QDate date) val = day->count(code) / hours; data = QString("%1").arg(val,0,'f',2); } + // TODO: percentage would be another useful option here for things like + // percentage of patient-triggered breaths, which is much more useful + // than the duration of timed breaths per hour. values[code] = val; QColor altcolor = (brightness(chan.defaultColor()) < 0.3) ? Qt::white : Qt::black; // pick a contrasting color html+=QString("%3%4\n")