chris/OSCAR-code
1
0
Fork 0
mirror of https://gitlab.com/pholy/OSCAR-code.git synced 2025-04-06 19:20:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add a few comments for future 900X improvements.

Browse Source
This commit is contained in:
sawinglogz 2019-06-19 17:50:41 -04:00
parent ec73958b4a
commit 423bfccc5a
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
oscar/SleepLib/loader_plugins/prs1_loader.cpp
View File

@ -5343,8 +5343,11 @@ bool PRS1Import::ParseSession(void)
qWarning() << sessionid << "compliance didn't set session end?"; qWarning() << sessionid << "compliance didn't set session end?";
} }
// Events and waveforms use updateLast() to set the session's last timestamp, // Events and use updateLast() to set the session's last timestamp,
// so they should only reach this point if there was a problem parsing them. // so they should only reach this point if there was a problem parsing them.
// TODO: It turns out waveforms *don't* update the timestamp, so this
// is depending entirely on events. See TODO below.
if (event != nullptr || !wavefile.isEmpty() || !oxifile.isEmpty()) { if (event != nullptr || !wavefile.isEmpty() || !oxifile.isEmpty()) {
qWarning() << sessionid << "Downgrading session to summary only"; qWarning() << sessionid << "Downgrading session to summary only";
} }
@ -5352,7 +5355,10 @@ bool PRS1Import::ParseSession(void)
// Only use the summary's duration if the session's duration couldn't be // Only use the summary's duration if the session's duration couldn't be
// derived from events or waveforms. // derived from events or waveforms.
// TODO: Revisit this once summary parsing is reliable.
// TODO: Change this once summary parsing is reliable: event duration is less
// accurate than either waveforms or correctly-parsed summaries, since there
// won't necessarily be events at the very end of a session.
session->really_set_last(session->first()+(qint64(summary_duration) * 1000L)); session->really_set_last(session->first()+(qint64(summary_duration) * 1000L));
} }
save = true; save = true;

3
oscar/daily.cpp
View File

@ -1457,6 +1457,9 @@ void Daily::Load(QDate date)
val = day->count(code) / hours; val = day->count(code) / hours;
data = QString("%1").arg(val,0,'f',2); data = QString("%1").arg(val,0,'f',2);
} }
// TODO: percentage would be another useful option here for things like
// percentage of patient-triggered breaths, which is much more useful
// than the duration of timed breaths per hour.
values[code] = val; values[code] = val;
QColor altcolor = (brightness(chan.defaultColor()) < 0.3) ? Qt::white : Qt::black; // pick a contrasting color QColor altcolor = (brightness(chan.defaultColor()) < 0.3) ? Qt::white : Qt::black; // pick a contrasting color
html+=QString("<tr><td align='left' bgcolor='%1'><b><font color='%2'><a href='event=%5' style='text-decoration:none;color:%2'>%3</a></font></b></td><td width=20% bgcolor='%1'><b><font color='%2'>%4</font></b></td></tr>\n") html+=QString("<tr><td align='left' bgcolor='%1'><b><font color='%2'><a href='event=%5' style='text-decoration:none;color:%2'>%3</a></font></b></td><td width=20% bgcolor='%1'><b><font color='%2'>%4</font></b></td></tr>\n")