From 8be2706623c16fcf6f0747d288c50522d32c3332 Mon Sep 17 00:00:00 2001
From: LoudSnorer <just4me.1947@gmail.com>
Date: Sat, 4 Mar 2023 16:45:57 -0500
Subject: [PATCH] add hide-show button to overview graph combo box

---
 oscar/overview.cpp | 66 +++++++++++++++++++++++++++++++---------------
 oscar/overview.h   |  5 ++++
 2 files changed, 50 insertions(+), 21 deletions(-)

diff --git a/oscar/overview.cpp b/oscar/overview.cpp
index 9ea1894e..265bb89e 100644
--- a/oscar/overview.cpp
+++ b/oscar/overview.cpp
@@ -459,12 +459,25 @@ void Overview::setGraphText () {
             if (!g->visible()) {
                 numOff++;
             }
+            //DEBUGFW  Q(numTotal) Q(numOff)  Q(g->name());
         }
     }
     ui->graphCombo->setItemIcon(0, numOff ? *icon_warning : *icon_up_down);
     QString graphText;
-    if (numOff == 0) graphText = QObject::tr("%1 Charts").arg(numTotal);
-    else             graphText = QObject::tr("%1 of %2 Charts").arg(numTotal-numOff).arg(numTotal);
+    int lastIndex = ui->graphCombo->count()-1;
+
+    if (numOff == 0) {
+        // all graphs are shown
+        graphText = QObject::tr("%1 Graphs").arg(numTotal);
+        ui->graphCombo->setItemText(lastIndex,STR_HIDE_ALL_GRAPHS);
+    } else {
+        // some graphs are hidden
+        graphText = QObject::tr("%1 of %2 Graphs").arg(numTotal-numOff).arg(numTotal);
+        if (numOff == numTotal) {
+            // all graphs are hidden
+            ui->graphCombo->setItemText(lastIndex,STR_SHOW_ALL_GRAPHS);
+        }
+    }
     ui->graphCombo->setItemText(0, graphText);
 }
 
@@ -473,7 +486,7 @@ void Overview::updateGraphCombo()
     ui->graphCombo->clear();
     gGraph *g;
 
-    ui->graphCombo->addItem(*icon_up_down, tr("10 of 10 Charts"), true); // Translation only to define space required
+    ui->graphCombo->addItem(*icon_up_down, "", true); 
     for (int i = 0; i < GraphView->size(); i++) {
         g = (*GraphView)[i];
 
@@ -485,7 +498,7 @@ void Overview::updateGraphCombo()
             ui->graphCombo->addItem(*icon_off, g->title(), false);
         }
     }
-
+    ui->graphCombo->addItem(*icon_on,STR_HIDE_ALL_GRAPHS,true);
     ui->graphCombo->setCurrentIndex(0);
     setGraphText();
     updateCube();
@@ -873,29 +886,40 @@ void Overview::setRange(QDate& start, QDate& end, bool updateGraphs/*zoom*/)
     updateGraphCombo();
 }
 
+void Overview::showGraph(int index,bool show, bool updateGraph) {
+    ui->graphCombo->setItemData(index,show,Qt::UserRole);
+    ui->graphCombo->setItemIcon(index, show ? *icon_on : *icon_off);
+    if (!updateGraph) return;
+    QString graphName = ui->graphCombo->itemText(index);
+    gGraph* graph=GraphView->findGraphTitle(graphName);
+    if (graph) graph->setVisible(show);
+}
+
+void Overview::showAllGraphs(bool show) {
+    //Skip over first button - label for comboBox
+    int lastIndex = ui->graphCombo->count()-1;
+    for (int i=1;i<lastIndex;i++) {
+        showGraph(i,show,true);
+    }
+}
+
+
 void Overview::on_graphCombo_activated(int index)
 {
-    if (index < 0) {
-        return;
-    }
-
-    if (index > 0 ) {
-        gGraph *g;
-        QString s;
-        s = ui->graphCombo->currentText();
-        bool b = !ui->graphCombo->itemData(index, Qt::UserRole).toBool();
-        ui->graphCombo->setItemData(index, b, Qt::UserRole);
-
-        if (b) {
-            ui->graphCombo->setItemIcon(index, *icon_on);
+   if (index<0) return;
+    if (index > 0) {
+        bool nextOn =!ui->graphCombo->itemData(index,Qt::UserRole).toBool();
+        int lastIndex = ui->graphCombo->count()-1;
+        if ( index == lastIndex ) {
+            // user just pressed hide show button - toggle states of the button and apply the new state
+            showAllGraphs(nextOn);
+            showGraph(index,nextOn,false);
         } else {
-            ui->graphCombo->setItemIcon(index, *icon_off);
+            showGraph(index,nextOn,true);
         }
-
-        g = GraphView->findGraphTitle(s);
-        g->setVisible(b);
         ui->graphCombo->showPopup();
     }
+
     ui->graphCombo->setCurrentIndex(0);
     updateCube();
     setGraphText();
diff --git a/oscar/overview.h b/oscar/overview.h
index 845e0b9c..9108442a 100644
--- a/oscar/overview.h
+++ b/oscar/overview.h
@@ -199,6 +199,11 @@ class Overview : public QWidget
     bool samePage;
 
     SaveGraphLayoutSettings* saveGraphLayoutSettings=nullptr;
+    QString STR_HIDE_ALL_GRAPHS =QString(tr("Hide All Graphs"));
+    QString STR_SHOW_ALL_GRAPHS =QString(tr("Show All Graphs"));
+    void showGraph(int index,bool show, bool updateGraph);
+    void showAllGraphs(bool show);
+
 };