From cdeba58c5dd60eebcead129e58b3b6232253421d Mon Sep 17 00:00:00 2001 From: sawinglogz <3787776-sawinglogz@users.noreply.gitlab.com> Date: Mon, 3 Feb 2020 11:43:13 -0500 Subject: [PATCH] Fix minor cleanup bugs in the Resmed regression tests that were causing crashes. --- oscar/SleepLib/profiles.cpp | 15 +++++++-------- oscar/tests/resmedtests.cpp | 2 +- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/oscar/SleepLib/profiles.cpp b/oscar/SleepLib/profiles.cpp index c58bd182..98e421dc 100644 --- a/oscar/SleepLib/profiles.cpp +++ b/oscar/SleepLib/profiles.cpp @@ -94,14 +94,6 @@ Profile::~Profile() removeLock(); } - delete user; - delete doctor; - delete cpap; - delete oxi; - delete appearance; - delete session; - delete general; - // delete machine objects... for (auto & mach : m_machlist) { delete mach; @@ -111,6 +103,13 @@ Profile::~Profile() delete day; } + delete user; + delete doctor; + delete cpap; + delete oxi; + delete appearance; + delete session; + delete general; } bool Profile::Save(QString filename) diff --git a/oscar/tests/resmedtests.cpp b/oscar/tests/resmedtests.cpp index 865bb0f5..6c6eb0c1 100644 --- a/oscar/tests/resmedtests.cpp +++ b/oscar/tests/resmedtests.cpp @@ -30,9 +30,9 @@ void ResmedTests::initTestCase(void) void ResmedTests::cleanupTestCase(void) { delete AppSetting; - delete p_pref; delete p_profile; p_profile = nullptr; + delete p_pref; }