chris/OSCAR-code
1
0
Fork 0
mirror of https://gitlab.com/pholy/OSCAR-code.git synced 2025-04-05 10:40:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Explain why no TZ conversion is needed for some graph methods

Browse Source 
The graph cursor and range text strings are computed from the graph's data which do not need to be converted to local time.  i.e. 5pm == 5pm.
This commit is contained in:
reznet 2015-08-11 15:38:09 -05:00
parent 81c0b06f06
commit f2218f14e5
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sleepyhead/Graphs/gGraphView.cpp
View File

@ -1385,6 +1385,14 @@ void gGraphView::paintGL()
QString gGraphView::getRangeString() QString gGraphView::getRangeString()
{ {
// a note about time zone usage here
// even though this string will be displayed to the user
// the graph is drawn using UTC times, so no conversion
// is needed to format the date and time for the user
// i.e. if the graph says the cursor is at 5pm, then that
// is what we should display.
// passing in UTC below is necessary to prevent QT
// from automatically converting the time to local time
QString fmt; QString fmt;
qint64 diff = m_maxx - m_minx; qint64 diff = m_maxx - m_minx;

5
sleepyhead/overview.cpp
View File

@ -475,7 +475,10 @@ gGraph *Overview::createGraph(QString code, QString name, QString units, YTicker
void Overview::on_LineCursorUpdate(double time) void Overview::on_LineCursorUpdate(double time)
{ {
if (time > 1) { if (time > 1) {
QDateTime dt = QDateTime::fromMSecsSinceEpoch(time,Qt::UTC); // even though the generated string is displayed to the user
// no time zone conversion is neccessary, so pass UTC
// to prevent QT from automatically converting to local time
QDateTime dt = QDateTime::fromMSecsSinceEpoch(time, Qt::UTC);
QString txt = dt.toString("dd MMM yyyy (dddd)"); QString txt = dt.toString("dd MMM yyyy (dddd)");
dateLabel->setText(txt); dateLabel->setText(txt);
} else dateLabel->setText(QString(GraphView->emptyText())); } else dateLabel->setText(QString(GraphView->emptyText()));